]> dgit.raspbian.org Git - gnome-shell.git/commitdiff
shellEntry: Make signal id variable private
authorJonas Dreßler <verdre@v0yd.nl>
Thu, 23 Jan 2020 21:37:06 +0000 (22:37 +0100)
committerFlorian Müllner <florian.muellner@gmail.com>
Thu, 30 Jan 2020 14:35:26 +0000 (14:35 +0000)
Signal connection IDs should be private variables, so make this one
private.

https://gitlab.gnome.org/GNOME/gnome-shell/merge_requests/952

js/ui/shellEntry.js

index c6e35fa83c6782ba94f411a2f82d1a2133533551..77e3a185ba497a4b62c492039921c60f1b3703dd 100644 (file)
@@ -165,19 +165,19 @@ class CapsLockWarning extends St.Label {
 
         this.connect('notify::mapped', () => {
             if (this.is_mapped()) {
-                this.stateChangedId = this._keymap.connect('state-changed',
+                this._stateChangedId = this._keymap.connect('state-changed',
                     this._updateCapsLockWarningOpacity.bind(this));
             } else {
-                this._keymap.disconnect(this.stateChangedId);
-                this.stateChangedId = 0;
+                this._keymap.disconnect(this._stateChangedId);
+                this._stateChangedId = 0;
             }
 
             this._updateCapsLockWarningOpacity();
         });
 
         this.connect('destroy', () => {
-            if (this.stateChangedId > 0)
-                this._keymap.disconnect(this.stateChangedId);
+            if (this._stateChangedId > 0)
+                this._keymap.disconnect(this._stateChangedId);
         });
 
         this.clutter_text.ellipsize = Pango.EllipsizeMode.NONE;